Revert "Make mutable generic collection interfaces implement read-only collection interfaces (#95830)" #101644
+199
−610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplicable (dotnet#101469)" This reverts commit e92b7d0.
…y collection interfaces (dotnet#95830)" This reverts commit a2bd583.
|
Note regarding the |
|
Tagging subscribers to this area: @dotnet/area-system-collections |
|
/backport to release/9.0-preview4 |
|
Started backporting to release/9.0-preview4: https://github.com/dotnet/runtime/actions/runs/8860536300 |
4 tasks
tannergooding
approved these changes
Apr 27, 2024
stephentoub
approved these changes
Apr 27, 2024
This was referenced Apr 27, 2024
jkotas
commented
Apr 27, 2024
|
I hope this gets merged back in. I was really excited to see this commit land. |
|
This is very sad to see. This was one of the most exciting change due in .Net 9 for me 😭 |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…y collection interfaces (dotnet#95830)" (dotnet#101644) * Revert "Update ICollection<T> usage to IReadOnlyCollection<T> where applicable (dotnet#101469)" This reverts commit e92b7d0. * Revert "Make mutable generic collection interfaces implement read-only collection interfaces (dotnet#95830)" This reverts commit a2bd583. * Update src/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
…y collection interfaces (dotnet#95830)" (dotnet#101644) * Revert "Update ICollection<T> usage to IReadOnlyCollection<T> where applicable (dotnet#101469)" This reverts commit e92b7d0. * Revert "Make mutable generic collection interfaces implement read-only collection interfaces (dotnet#95830)" This reverts commit a2bd583. * Update src/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…y collection interfaces (dotnet#95830)" (dotnet#101644) * Revert "Update ICollection<T> usage to IReadOnlyCollection<T> where applicable (dotnet#101469)" This reverts commit e92b7d0. * Revert "Make mutable generic collection interfaces implement read-only collection interfaces (dotnet#95830)" This reverts commit a2bd583. * Update src/coreclr/System.Private.CoreLib/src/System/Array.CoreCLR.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces ambiguous call error for calls of IList.Count in C++/CLI.
dotnet/wpf#9055 (comment)