-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #92375 and #93082 to release/8.0-staging #101744
Backport #92375 and #93082 to release/8.0-staging #101744
Conversation
Note regarding the
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not strictly necessary to backport new tests, but not a problem if it makes porting easier. This won’t work for net6 because Native aot wasn’t supported then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks for letting me know. I'll make the PR simpler in that case, hoping that it can be directly backported to net6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm although we only strictly need to port changes to runtime-official and dependencies thereof. If possible I would try to avoid other changes that may change behavior for only the public build.
895af02
to
ee04040
Compare
ee04040
to
5acba8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we can take this as tell mode
37a6d07
into
dotnet:release/8.0-staging
This is part of the work to transition to the 1ES templates in servicing branches.
PR #92375 was cleanly cherry-picked, except for changes in eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml which were discarded.
For PR #93082, only the changes in
eng/pipelines/runtime*.yml
were included as the others are not required.Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2442616&view=results
cc @jkoritzinsky @agocke @amanasifkhalid