-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide MSBuild properties to use the new libc++ configuration we plan on using in our builds #101773
Conversation
…n on using in our builds.
…ers that we've migrated to azurelinux-3.0-based containers.
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Co-authored-by: Sven Boemer <sbomer@gmail.com>
…ge the entry-point ones to be different so MSBuild global property behavior doesn't break things).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Co-authored-by: Sven Boemer <sbomer@gmail.com>
Now that the images have been published, let's try to use the new features. |
/azp run runtime-sanitized |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-sanitized |
Azure Pipelines successfully started running 1 pipeline(s). |
Looks like there's some failures due to some of the later changes I made in the images that I didn't go back and re-validate. I'll only opt-in to the new images for the sanitizer build (which is failing for other reasons) but I'll keep the infra around for when I fix the problem. |
Blocked on dotnet/dotnet-buildtools-prereqs-docker#1055 |
/ba-g Timeouts unrelated |
…n on using in our builds (dotnet#101773) Co-authored-by: Sven Boemer <sbomer@gmail.com>
We're going to switch our Microsoft shipping builds to statically link to a live-built libc++ with a dynamically-linked libstdc++ as the C++ ABI. We're doing this change to address the concerns in #101088 (comment). This change will allow us to use servicable/supported C++ headers in our product with the smallest possible size increase (+~53kB size on disk for libcoreclr.so on our linux-x64 images).
For our AddressSanitizer test legs, we're introducing a new image that instruments libc++ and uses (and instruments) libc++abi for the ABI layer (all statically linked).
Depends on dotnet/dotnet-buildtools-prereqs-docker#1025, but I want to get this UX approved before I merge that PR.
No changes were made in the libraries build as that build is all in C as far as I know.