Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide MSBuild properties to use the new libc++ configuration we plan on using in our builds #101773

Merged
merged 10 commits into from
May 15, 2024

Conversation

jkoritzinsky
Copy link
Member

We're going to switch our Microsoft shipping builds to statically link to a live-built libc++ with a dynamically-linked libstdc++ as the C++ ABI. We're doing this change to address the concerns in #101088 (comment). This change will allow us to use servicable/supported C++ headers in our product with the smallest possible size increase (+~53kB size on disk for libcoreclr.so on our linux-x64 images).

For our AddressSanitizer test legs, we're introducing a new image that instruments libc++ and uses (and instruments) libc++abi for the ABI layer (all statically linked).

Depends on dotnet/dotnet-buildtools-prereqs-docker#1025, but I want to get this UX approved before I merge that PR.

No changes were made in the libraries build as that build is all in C as far as I know.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

src/coreclr/runtime.proj Outdated Show resolved Hide resolved
src/native/corehost/corehost.proj Outdated Show resolved Hide resolved
src/native/corehost/corehost.proj Outdated Show resolved Hide resolved
eng/Subsets.props Outdated Show resolved Hide resolved
eng/Subsets.props Outdated Show resolved Hide resolved
Co-authored-by: Sven Boemer <sbomer@gmail.com>
…ge the entry-point ones to be different so MSBuild global property behavior doesn't break things).
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

eng/Subsets.props Outdated Show resolved Hide resolved
eng/pipelines/common/global-build-job.yml Outdated Show resolved Hide resolved
Co-authored-by: Sven Boemer <sbomer@gmail.com>
@jkoritzinsky
Copy link
Member Author

Now that the images have been published, let's try to use the new features.

@jkoritzinsky
Copy link
Member Author

/azp run runtime-sanitized

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run runtime-sanitized

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

Looks like there's some failures due to some of the later changes I made in the images that I didn't go back and re-validate. I'll only opt-in to the new images for the sanitizer build (which is failing for other reasons) but I'll keep the infra around for when I fix the problem.

@jkoritzinsky jkoritzinsky requested a review from sbomer May 14, 2024 21:56
@jkoritzinsky jkoritzinsky added the blocked Issue/PR is blocked on something - see comments label May 14, 2024
@jkoritzinsky
Copy link
Member Author

@jkoritzinsky
Copy link
Member Author

/ba-g Timeouts unrelated

@jkoritzinsky jkoritzinsky merged commit 44d919d into dotnet:main May 15, 2024
133 of 148 checks passed
@jkoritzinsky jkoritzinsky deleted the static-libcxx branch May 15, 2024 18:47
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
…n on using in our builds (dotnet#101773)

Co-authored-by: Sven Boemer <sbomer@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure blocked Issue/PR is blocked on something - see comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants