Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explosed -> exposed #101836

Merged
merged 1 commit into from May 4, 2024
Merged

explosed -> exposed #101836

merged 1 commit into from May 4, 2024

Conversation

ghost
Copy link

@ghost ghost commented May 3, 2024

change(s) made include:

  1. rectified the word explosed to exposed.

incentive: I hope no API exploses >~< (oui, oui!).

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 3, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 3, 2024
This was referenced May 3, 2024
Closed
Closed
Closed
stephentoub
stephentoub approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ghost
Copy link
Author

ghost commented May 3, 2024

I understand this is little/insignificant as a contribution...

however! it is an important step for me!
as I'd love to become an active contributor of the dotnet/runtime repository!
it's just a matter of lack of essential programming knowledge... but you'll see more from me!

keep an eye, and you'll see (I mean, I don't know if one can see without eyes lulz xd).

@danmoseley
Copy link
Member

@ophura you're welcome here. Maybe look at issues labeled good first issue.

@ghost
Copy link
Author

ghost commented May 3, 2024

arigato! >~<

@build-analysis build-analysis bot mentioned this pull request May 4, 2024
Closed
This was referenced May 4, 2024
Open
Open
explosed -> exposed
25b080b 
change(s) made include:

1. rectified the *word* `explosed` to `exposed`.

incentive: I hope no API *exploses* >~< (oui, oui!).
This was referenced May 4, 2024
Closed
Open
Closed
@danmoseley
Copy link
Member

@stephentoub what's the process nowadays when there's validation failures that are unrelated?

@stephentoub
Copy link
Member

stephentoub commented May 4, 2024 •
edited
Loading

@stephentoub what's the process nowadays when there's validation failures that are unrelated?

If the build analysis leg is green, you can merge. It is here.

@danmoseley danmoseley merged commit deb7c17 into dotnet:main May 4, 2024
143 of 146 checks passed
@danmoseley
Copy link
Member

That's easy

@ghost
Copy link
Author

ghost commented May 4, 2024

yahooo! I made it in folks! xd
things are getting serious!

today I changed a letter, tomorrow however!
I just might revamp the whole thing xd

thankies for appreciation <3

@ghost ghost deleted the patch-1 branch May 4, 2024 15:47
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@michaelgsharp
explosed -> exposed (dotnet#101836)
ca9dc28
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@Ruihan-Yin
explosed -> exposed (dotnet#101836)
8d8bdec
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danmoseley @stephentoub