Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Typo in comment in Boolean.cs #101855

Closed
wants to merge 1 commit into from

Conversation

Dawso125
Copy link

@Dawso125 Dawso125 commented May 3, 2024

There is a typo that exists on the "False" Comment in line 111 of Boolean.cs. This PR Fixes "Fals" to "False"

There is a typo that exists on the "False" Comment in line 111 of Boolean.cs. This PR Fixes "Fals" to "False"
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 3, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 3, 2024
@@ -108,7 +108,7 @@ public bool TryFormat(Span<char> destination, out int charsWritten)
{
if (destination.Length > 4)
{
ulong fals_val = BitConverter.IsLittleEndian ? 0x73006C00610046ul : 0x460061006C0073ul; // "Fals"
ulong fals_val = BitConverter.IsLittleEndian ? 0x73006C00610046ul : 0x460061006C0073ul; // "False"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a typo - 0x73006C00610046ul represents 4 chars of "False" -> "Fals"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants