-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify and test that 0x
is case-invariant in the Convert class
#101876
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Tagging subscribers to this area: @dotnet/area-system-numerics |
Are there tests for all these already |
This is already covered in the official docs under the remarks section: https://learn.microsoft.com/en-us/dotnet/api/system.convert.tobyte?view=net-8.0#system-convert-tobyte(system-string-system-int32)
Looks like no, @Dubzer would you mind adding explicit coverage to the various |
@tannergooding sure! I'll add it to my PR when I have time |
0x
is case-invariant in the Convert class0x
is case-invariant in the Convert class
@tannergooding done! I've added tests and also fixed small comment typo for the ToString method |
Hi!
I was confused by the comment, so decided to specify that method can accept
0x
and0X
as a prefix for hex numbers