Move unicodedata to minipal #102139
Merged
Move unicodedata to minipal #102139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
am11
commented
May 12, 2024
|
Moving to minipal is bringing related code together. We can also hook it in mono to address things like runtime/src/mono/mono/eglib/glib.h Line 408 in 42c2362 |
This was referenced May 13, 2024
Closed
jkotas
reviewed
May 13, 2024
jkotas
reviewed
May 13, 2024
jkotas
reviewed
May 13, 2024
jkotas
reviewed
May 13, 2024
src/native/minipal/utf8.h
Outdated
| * @param code The UTF-16 character to be converted. | ||
| * @return The uppercase equivalent of the character or the character itself if no conversion is necessary. | ||
| */ | ||
| CHAR16_T minipal_toupper_invariant(CHAR16_T code); |
There was a problem hiding this comment.
These two methods have nothing to do with UTF8. Should they be in a separate header?
There was a problem hiding this comment.
This header was dealing with UTF-8 and UTF-16, so I put them here. They can be moved to a separate one e.g. minipal/unicodedata.h?
There was a problem hiding this comment.
Yes, that would work. (Alternative: give the header a more generic name.)
am11
force-pushed
the
feature/minipal/unicodedata
branch
from
2e843b9
to
e649c7b
Compare
jkotas
reviewed
May 15, 2024
C mode (/TC) requires explicit windows.h as opposed to C++ mode (/TP).
jkotas
reviewed
May 15, 2024
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
* Move unicodedata to minipal * Fix linux build * Shave off a few bytes with 'static const' * Add a separate header * Regenerate unicodedata.c * Cleanups
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relocated next to utf8.c. Data generation mechanism remained the same: