-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FrozenSet.Create collection builder #102223
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really related to this PR, but with all the improvements around
ROSpan<T>
(params, the new language support that makesROSpan<T>
the preferred overload, collection expression, etc) do we have any plans to expose constructor overloads on the various collection types so this can just benew(source)
, much like we could if it had been anIEnumerable<T>
?Seems like a generally good thing that can simplify the patterns for common user scenarios. -- Notable doing
HashSet<T> set = [..source];
works as well, its just not super efficient today and looks to go through the enumerator not the specialfor (...)
iteration that span normally gets.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd like to, but we can't do that well yet. Even with how the current first-class span support is defined, if HashSet gained a
HashSet<T>(ReadOnlySpan<T>)
overload and you tried to call that with an array, it would fail to compile due to ambiguity, since array can implicitly convert to bothIEnumerable<T>
andReadOnlySpan<T>
.This should however resolve itself if/when we make
ReadOnlySpan<T> : IEnumerable<T>
, as that will result inReadOnlySpan<T>
being considered better for overload resolution. The ref struct work just landed in Roslyn main today. Once that lands in runtime and I can more easily vet it, my plan is to create a proposal for the resulting improvements we should make in .NET 9, including where we want to annotate with allow ref struct (e.g. delegates, enumerable) and what new APIs we can then expose that we've been wanting to (e.g. that ctor on HashSet).