Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Switch off HybridGlobalization lane on v8 on CI #102447

Merged
merged 1 commit into from
May 20, 2024

Conversation

ilonatommy
Copy link
Member

Backport of #101671 to release/8.0-staging.

This PR removes HybridGlobalization tests on v8.

Customer Impact

None, it's CI testing.
Fixes #102348.

Regression

No.

We always tested v8.

Testing, Risk

No testing planned, low risk - customers don't use HG on v8.
Maintaining HybridGlobalization tests takes considerable effort - the API response might change with each host version and it does not mean that they are incorrect. As the result, with each version change we have to update expected test results.
HybridGlobalization is primarily targeting browser and node. While updating the tests for browser and node makes sense - to catch any changes that are indeed invalid - updating it for v8 is a not necessary effort.

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@ilonatommy ilonatommy added the Servicing-consider Issue for next servicing release review label May 20, 2024
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting. This is a test-only fix so we can treat it as tell-mode.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 20, 2024
@carlossanlop carlossanlop merged commit a490202 into dotnet:release/8.0-staging May 20, 2024
111 of 115 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Globalization Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants