-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows CNG virtualization-based security #102495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krwq
added
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
area-System.Security
labels
May 21, 2024
Note regarding the
|
vcsjones
reviewed
May 22, 2024
src/libraries/System.Security.Cryptography/tests/CngKeyTests.cs
Outdated
Show resolved
Hide resolved
krwq
removed
the
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
May 28, 2024
vcsjones
reviewed
May 28, 2024
src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs
Outdated
Show resolved
Hide resolved
This was referenced Jun 7, 2024
bartonjs
reviewed
Jun 17, 2024
src/libraries/Common/tests/System/Security/Cryptography/CngPlatformProviderKey.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jun 17, 2024
src/libraries/System.Security.Cryptography/tests/CngKeyTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 9, 2024
Open
bartonjs
reviewed
Jul 11, 2024
src/libraries/Common/tests/System/Security/Cryptography/CngKeyWrapper.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jul 11, 2024
src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Jul 17, 2024
bartonjs
added
the
cryptographic-docs-impact
Issues impacting cryptographic docs. Cleared and reused after documentation is updated each release.
label
Aug 15, 2024
bartonjs
added
the
tracking
This issue is tracking the completion of other related issues.
label
Aug 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Security
cryptographic-docs-impact
Issues impacting cryptographic docs. Cleared and reused after documentation is updated each release.
new-api-needs-documentation
tracking
This issue is tracking the completion of other related issues.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #102492
One of the Windows 11 builds has added framework to help secure Windows keys with virtualization-based security (VBS). With this new capability, keys can be protected from admin-level key theft attacks with negligible effect on performance, reliability, or scale.
Blog post:
https://techcommunity.microsoft.com/t5/windows-it-pro-blog/advancing-key-protection-in-windows-using-vbs/ba-p/4050988
Win API:
https://learn.microsoft.com/en-us/windows/win32/api/ncrypt/nf-ncrypt-ncryptcreatepersistedkey
The proposal is to extend existing
CngKeyCreationOptions
API to include the new flags.API Proposal
Example usage