LSRA: Make genRegMask() return regMaskTP
#102783
Conversation
…ffect on non-LSRA code
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@shushanhf @dotnet/samsung |
|
@dotnet/jit-contrib @jakobbotsch PTAL |
| // TODO: Populate regMaskTP based on reg | ||
| return genSingleTypeRegMask(reg); |
There was a problem hiding this comment.
Even with predicate registers I would expect us to end up with basically the same logic as before, i.e. something like regMaskTP(1) << reg, probably encapsulating that operation inside regMaskTP. That is, we leave the regNumber mappings for predicate registers to just follow the float registers so that all reg numbers are unique.
Of course LSRA is going to need slightly different logic to map SingleTypeRegSet to regMaskTP which ends up requiring additional context about the type of set.
There was a problem hiding this comment.
yes, we basically will use the old logic of genRegMask() and use that value to set appropriate field of regMaskTP.
| #ifdef TARGET_AMD64 | ||
| return RBM_FLT_CALLEE_TRASH.GetFloatRegSet(); | ||
| #else | ||
| return RBM_FLT_CALLEE_TRASH; | ||
| #endif // TARGET_AMD64 |
There was a problem hiding this comment.
yeah, for amd64, RBM_FLT_CALLEE_TRASH maps to get_RBM_FLT_CALLEE_TRASH() which returns regMaskTP but for other platforms, it is just uint64_t or SingleTypeRegSet.
There was a problem hiding this comment.
I will see if I can unify this in future as this work evolves.
| #ifdef TARGET_AMD64 | ||
| availableFloatRegs = RBM_ALLFLOAT.GetFloatRegSet(); | ||
| availableDoubleRegs = RBM_ALLDOUBLE.GetFloatRegSet(); | ||
| #else | ||
| availableFloatRegs = RBM_ALLFLOAT; | ||
| availableDoubleRegs = RBM_ALLDOUBLE; |
There was a problem hiding this comment.
Same question, can this use the AMD64 logic for everyone?
| #ifdef TARGET_XARCH | ||
| freeRegs &= RBM_CALLEE_TRASH.GetRegSetForType(type); | ||
| #else | ||
| freeRegs &= RBM_CALLEE_TRASH; | ||
| #endif |
|
/ba-g failures are dotnet/dnceng#2378 and #102773 |
* genRegMask * Make genRegMask() return regMaskTP, introduce genSingleTypeRegMask() for LSRA * Make allFloat,allMask regMaskTP instead of `SingleTypeRegSet` so no affect on non-LSRA code * jit format * fix build errors * fix loongarch and risc * fix a typo * move more `genSingleTypeRegMask()` * jit format * Make genRegMask() use genSingleType*() * fix build errors * jit format
Address feedback in #102592 (comment)
genRegMask()fromSingleTypeRegSettoregMaskTPrbmAllFloatfromSingleTypeRegSettoregMaskTPgenSingleTypeRegMask()that will be used in LSRA whenever we want to map a register number to the maskgenRegMask()will continue to returnregMaskTPthat will be used in non-LSRA code base.