-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression in Number.NumberBuffer.cs #102950
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Jun 1, 2024
Tagging subscribers to this area: @dotnet/area-system-numerics |
@EgorBot -arm64 -intel -mono using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
namespace System.Tests
{
public class Perf_Double
{
public static IEnumerable<object> Values => new object[]
{
double.MinValue,
12345.0 /* same value used by other tests to compare the perf */,
double.MaxValue
};
public static IEnumerable<object> StringValues
// r is used to fromat Min and Max values to a parsable string https://stackoverflow.com/a/767011
=> Values.OfType<double>().Select(value => value.ToString("r")).ToArray();
[Benchmark]
[ArgumentsSource(nameof(StringValues))]
[MemoryRandomization]
public double Parse(string value) => double.Parse(value);
[Benchmark]
[ArgumentsSource(nameof(StringValues))]
[MemoryRandomization]
public bool TryParse(string value) => double.TryParse(value, out _);
}
} |
Benchmark results on Intel
|
Benchmark results on Arm64
|
This was referenced Jun 1, 2024
jkotas
approved these changes
Jun 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This was referenced Jun 14, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Numerics
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102865