Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base64Fuzzer to the repo #103011

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Add Base64Fuzzer to the repo #103011

merged 4 commits into from
Jun 7, 2024

Conversation

buyaa-n
Copy link
Member

@buyaa-n buyaa-n commented Jun 3, 2024

Add Base64Fuzzer to the repo

Related to #102364 (review)

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@buyaa-n buyaa-n mentioned this pull request Jun 3, 2024
4 tasks
@MihaZupan
Copy link
Member

@MihuBot fuzz base64

Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fuzzing part LGTM.

The System.Buffers area may want to check if this is covering all the paths we care about for Base64.

@buyaa-n
Copy link
Member Author

buyaa-n commented Jun 5, 2024

The System.Buffers area may want to check if this is covering all the paths we care about for Base64.

Well, Base64 doesn't have so many APIs, and this PR covers all those APIs. There could be scenario where whitespaces involved in decoding, but I am not sure how to tell the fuzzer to generate valid base64 bytes with whitespaces, looks there is no way except insert white spaces manually after encoding.

@buyaa-n buyaa-n merged commit 2dba5a3 into dotnet:main Jun 7, 2024
80 of 83 checks passed
@buyaa-n buyaa-n deleted the base64-fuzzer branch June 7, 2024 16:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants