Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[interp] handle box + brtrue/brfalse and box+isinst+unbox.any patterns up front #103052

Merged
merged 7 commits into from
Jun 9, 2024
Merged

[interp] handle box + brtrue/brfalse and box+isinst+unbox.any patterns up front #103052

merged 7 commits into from
Jun 9, 2024

Commits on Jun 4, 2024

  1. [interp] handle box + brtrue/brfalse pattern for byreflike types 

    In cases where we don't do cprop and deadce (for example if
~mono_interp_opt~ is 0 because we're debugging) don't emit a box_vt
opcode before a branch.  Instead just emit a constant true

Fixes dotnet#102988
    @lambdageek
    lambdageek committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    74e4871 View commit details
    Browse the repository at this point in the history

  2. Revert "Revert uses of Unsafe.BitCast with spans to unblock mono (dot… 

    …net#102998)"

This reverts commit c286a8e.
    @lambdageek
    lambdageek committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9268a9c View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. remove the box byreflike retry code 

    we handle box byreflike code patterns directly now
    @lambdageek
    lambdageek committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    faa8e79 View commit details
    Browse the repository at this point in the history

  2. handle box;isinst;{brtrue|brfalse|unbox.any} IL patterns

    @lambdageek
    lambdageek committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    d586ae2 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Add test locking down mismatched box;isinst;unbox.any pattern

    @lambdageek
    lambdageek committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    21c07bb View commit details
    Browse the repository at this point in the history

  2. remove the mismatch case in the interp. throw IPE at execution time

    @lambdageek
    lambdageek committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a79241d View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Update src/tests/Loader/classloader/generics/ByRefLike/Validate.cs 

    Co-authored-by: Aaron Robinson <arobins@microsoft.com>
    @lambdageek @AaronRobinsonMSFT
    lambdageek and AaronRobinsonMSFT authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    e0027f1 View commit details
    Browse the repository at this point in the history