Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the thread alloc context off of Thread in CoreCLR #103055

Merged
merged 20 commits into from
Jun 17, 2024
Merged

Move the thread alloc context off of Thread in CoreCLR #103055

merged 20 commits into from
Jun 17, 2024

Commits on Jun 5, 2024

  1. Move the thread alloc context off of Thread in CoreCLR and NativeAOT

    @jkoritzinsky
    jkoritzinsky committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    86e6837 View commit details
    Browse the repository at this point in the history

  2. fix typo

    @jkoritzinsky
    jkoritzinsky committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    a96039a View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Remove extra indirection. use same thread-local model as in other cas… 

    …es to enable MSVC to optimize dynamic TLS initialization away. Clean up comments. Fix NativeAOT emulated TLS
    @jkoritzinsky
    jkoritzinsky committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e511c4f View commit details
    Browse the repository at this point in the history

  2. Fix ARM64 asm

    @jkoritzinsky
    jkoritzinsky committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d81012e View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Fix indexing on x86

    @jkoritzinsky
    jkoritzinsky committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    c2cbeb6 View commit details
    Browse the repository at this point in the history

  2. Fix root enumeration and ensure we're initializing/reading the right … 

    …alloc context for the correct thread.
    @jkoritzinsky
    jkoritzinsky committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    71eb0f4 View commit details
    Browse the repository at this point in the history

  3. Remove the GetThread call in JIT_NewS_MP_FastPortable as it's unneces… 

    …sary now.
    @jkoritzinsky
    jkoritzinsky committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    a87c3af View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Remove most of the inline-assembly alloc helpers. These helpers now h… 

    …ave nearly identical assembly as the (raw hcall impl) portable helpers in jithelpers.cpp. Use those instead.

Leave JIT_Box's assembly helper as we can't get quite as good of codegen with a portable helper today (and we don't even have one at the moment)
    @jkoritzinsky
    jkoritzinsky committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    ce489a8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'alloc-context-no-thread' of https://github.com/jkoritzi… 

    …nsky/runtime into alloc-context-no-thread
    @jkoritzinsky
    jkoritzinsky committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    0d40a74 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Fix contracts

    @jkoritzinsky
    jkoritzinsky committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a4b5ba4 View commit details
    Browse the repository at this point in the history

  2. Use a different reinit mechanism to ensure we're getting the behavior… 

    … we want.
    @jkoritzinsky
    jkoritzinsky committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a8eec35 View commit details
    Browse the repository at this point in the history

  3. Now that the alloc context is stored in TLS memory, we must clean it … 

    …up when a thread dies, as the TLS memory will be released
    @jkoritzinsky
    jkoritzinsky committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    190abb5 View commit details
    Browse the repository at this point in the history

  4. More null checks and allow a thread to clean itself up in OnThreadTer… 

    …minate (which does all the same cleanup as DetachThread, but in a scenario where we can actually clean up the object as well).
    @jkoritzinsky
    jkoritzinsky committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    f090a19 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Revert NativeAOT changes

    @jkoritzinsky
    jkoritzinsky committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5ed8f7a View commit details
    Browse the repository at this point in the history

  2. Update comment

    @jkoritzinsky
    jkoritzinsky committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6e74fda View commit details
    Browse the repository at this point in the history

  3. Update dacdbiimpl.cpp 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @jkoritzinsky @jkotas
    jkoritzinsky and jkotas authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    0ee2b52 View commit details
    Browse the repository at this point in the history

  4. PR feedback

    @jkoritzinsky
    jkoritzinsky committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    d895031 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'alloc-context-no-thread' of https://github.com/jkoritzi… 

    …nsky/runtime into alloc-context-no-thread
    @jkoritzinsky
    jkoritzinsky committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1929904 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2024

  1. PR feedback

    @jkoritzinsky
    jkoritzinsky committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    af270e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Revert instruction reduction (as it doesn't work with MASM SECTIONREL… 

    … sizing)
    @jkoritzinsky
    jkoritzinsky committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    bad14bf View commit details
    Browse the repository at this point in the history