Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][aot] Do not overwrite scenarios argument if they were passed #103229

Merged
merged 10 commits into from
Jun 12, 2024

Conversation

ilonatommy
Copy link
Member

Continuation of switching off HybridGlobalization tests on v8. HybridGlobalization_AOT lane on CI was still running V8 because it was overwriting the scenarios argument passed here:

Example of run with v8 on:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=702059&view=logs&j=2c5d15bf-ca52-57a8-9a4e-bb898fb954b8

Now we don't overwrite if scenarios is already defined.

@ilonatommy ilonatommy self-assigned this Jun 10, 2024
@ilonatommy ilonatommy requested a review from akoeplinger as a code owner June 10, 2024 15:15
@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines failed to run 1 pipeline(s).

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@ilonatommy ilonatommy closed this Jun 11, 2024
@ilonatommy ilonatommy reopened this Jun 11, 2024
@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@ilonatommy
Copy link
Member Author

@akoeplinger, most probably I have an indent/syntax problem that I cannot spot, could you please take a look?

@akoeplinger
Copy link
Member

@ilonatommy it looks like some issue with the empty parameter: https://dev.azure.com/dnceng-public/public/_build/results?buildId=703502&view=results

image

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@ilonatommy
Copy link
Member Author

@ilonatommy it looks like some issue with the empty parameter: https://dev.azure.com/dnceng-public/public/_build/results?buildId=703502&view=results

Thank you, I did not look there 🤦

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

ilonatommy commented Jun 11, 2024

LibraryTests_HybridGlobalization_AOT WasmTestOnNodeJS and WasmTestOnChrome

_buildAOTFunc publish/ProxyProjectForAOTOnHelix.proj /root/helix/work/workitem/uploads/xharness-output/AOTBuild.binlog /p:RunAOTCompilation=true ^&^& cd wasm_build/AppBundle ^&^& dotnet exec /root/helix/work/correlation/microsoft.dotnet.xharness.cli/9.0.0-prerelease.24277.1/tools/net8.0/any/Microsoft.DotNet.XHarness.CLI.dll wasm test --app=. --output-directory=/root/helix/work/workitem/uploads/xharness-output -s dotnet.native.js.symbols --symbol-patterns wasm-symbol-patterns.txt --symbolicator WasmSymbolicator.dll,Microsoft.WebAssembly.Internal.SymbolicatorWrapperForXHarness --timeout=00:30:00 --engine=NodeJS --engine-arg=--stack-trace-limit=1000 --engine-arg=--experimental-wasm-eh --js-file=test-main.js  --   --setenv=NPM_MODULES= --run WasmTestRunner.dll System.Xml.Linq.xNodeBuilder.Tests.dll  -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-103229-merge-01a097b651cc4d9d9b/WasmTestOnNodeJS-ST-System.Xml.Linq.xNodeBuilder.Tests/1/console.9acd24b4.log?helixlogtype=result

/root/helix/work/correlation/build/wasm-shared/WasmApp.Common.targets(513,5): error : Specified Emscripten sdk at $(EMSDK_PATH)=/root/helix/work/correlation/build/emsdk/ is missing some paths: $(EmscriptenNodeToolsPath)=/root/helix/work/correlation/build/emsdk/node/bin/ . SDK is required for AOT'ing assemblies. 

is #51746, so we cannot enable running them yet, I will have to block HybridGlobalization_AOT till it's resolved. But generally the PR serves its purpose.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Globalization disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants