Disable newly added System.Resources.Extensions tests with native AOT #103269
Conversation
Native AOT outerloop testing is on the floor due to build breaks: Build break 1: ``` The published project has a runtimeconfig.template.json that is not supported by PublishAot. Move the configuration to the project file using RuntimeHostConfigurationOption. ``` Build break 2 (this is a warning, but WarnAsError makes this more severe): ``` AOT analysis error IL3054: FluentAssertions.Equivalency.EquivalencyAssertionOptions`1<IEnumerable`1<IEnumerable`1<IEnumerable`1<IEnumerable`1<Int32[,,]>>>>>: Generic expansion to 'FluentAssertions.Equivalency.EquivalencyAssertionOptions`1<IEnumerable`1<IEnumerable`1<IEnumerable`1<IEnumerable`1<IEnumerable`1<Int32[,,]>>>>>>' was aborted due to generic recursion. An exception will be thrown at runtime if this codepath is ever reached. Generic recursion also negatively affects compilation speed and the size of the compilation output. It is advisable to remove the source of the generic recursion by restructuring the program around the source of recursion. The source of generic recursion might include: 'FluentAssertions.Equivalency.EquivalencyAssertionOptions`1', 'FluentAssertions.Equivalency.NestedExclusionOptionBuilder`2' ```
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The remaining outerloop failures are expected and will be fixed with #103248. |
No worries. Before I hit merge, am I correct to assume that this doesn't test any interesting "runtime behaviors"? (It's testing just run-off-the-mill library code?) If there's runtime behaviors, I would disable this on an Issue, but otherwise just keep it like this because an issue would likely be never fixed anyway. |
I'll merge now because I need to be able to run native AOT testing in another PR. |
Ah right, the cla service seems to be down, so no merging for me. Yay required statuses. |
|
I believe @adamsitnik has getting rid of fluent assertions on the TODO list. Once that happens, this can be turned back on for native AOT. |
|
Merged with admin override |
Thank you!
That's great to hear! |
That is true, you can expect that somewhen next week. |
|
I've created an issue for that: #103278 |
Native AOT outerloop testing is on the floor due to build breaks:
Build break 1:
Build break 2 (this is a warning, but WarnAsError makes this more severe):
Cc @dotnet/ilc-contrib