Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/arcade #103279

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 11, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20240611.10
  • Date Produced: June 12, 2024 3:03:13 AM UTC
  • Commit: ef3e671d0a92f5e7ebef53cd15b44b33dd04ef25
  • Branch: refs/heads/main

…611.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.1
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Jun 11, 2024
@DragosDanielBoia
Copy link
Contributor

@dotnet-policy-service rerun

1 similar comment
@DragosDanielBoia
Copy link
Contributor

@dotnet-policy-service rerun

…611.10

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10
…611.10

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10
@agocke
Copy link
Member

agocke commented Jun 12, 2024

@ViktorHofer can you take a look at these new test failures from arcade?

@lewing
Copy link
Member

lewing commented Jun 12, 2024

The official build is blocked on this update

@ViktorHofer
Copy link
Member

The official build is blocked on this update

Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?

@lewing
Copy link
Member

lewing commented Jun 12, 2024

The official build is blocked on this update

Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?

when it wasn't failing from infra it was failing from https://dev.azure.com/dnceng/internal/_build/results?buildId=2471323&view=logs&j=5c24930e-0ae1-546c-7353-8c3b261a7651&t=90d1b216-f511-5956-2766-23f92c36b673&l=21

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 12, 2024

Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?

@lewing
Copy link
Member

lewing commented Jun 12, 2024

Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?

#103355

@agocke
Copy link
Member

agocke commented Jun 12, 2024

@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?

Overall, I'd rather not pick and choose arcade changes. It puts us in a split state.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 12, 2024

@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?

We are talking about an external component here, xunit. We might be able to pin to an older version in runtime but as we compile against a newer version in Arcade and reference those components (i.e. XUnitExtensions and XUnitAssert) that might not work.

Other repositories already took a dependency on the newer xunit version (templating & sdk) so we can't (and don't want to) go back on an older version of xunit in Arcade.

Given that #103355 fixes the official build, I'm not sure if there's a better option here.

The issue here is just that some of our tests are written incorrectly as they assert on a behavior which was never guaranteed and which now changed with the xunit update.

xunit added a new event source that we need to filter out: xunit/xunit#2884
@akoeplinger
Copy link
Member

/ba-g test failure in System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds is unrelated

@akoeplinger akoeplinger merged commit 92534ff into main Jun 12, 2024
158 of 162 checks passed
@akoeplinger akoeplinger deleted the darc-main-92f07a0d-b69c-4e84-8263-881d34bec968 branch June 12, 2024 21:17
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants