-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/arcade #103279
[main] Update dependencies from dotnet/arcade #103279
Conversation
…611.1 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.1
@dotnet-policy-service rerun |
1 similar comment
@dotnet-policy-service rerun |
…611.10 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10
…611.10 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10
@ViktorHofer can you take a look at these new test failures from arcade? |
The official build is blocked on this update |
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds? |
when it wasn't failing from infra it was failing from https://dev.azure.com/dnceng/internal/_build/results?buildId=2471323&view=logs&j=5c24930e-0ae1-546c-7353-8c3b261a7651&t=90d1b216-f511-5956-2766-23f92c36b673&l=21 |
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that? |
|
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow? Overall, I'd rather not pick and choose arcade changes. It puts us in a split state. |
We are talking about an external component here, xunit. We might be able to pin to an older version in runtime but as we compile against a newer version in Arcade and reference those components (i.e. XUnitExtensions and XUnitAssert) that might not work. Other repositories already took a dependency on the newer xunit version (templating & sdk) so we can't (and don't want to) go back on an older version of xunit in Arcade. Given that #103355 fixes the official build, I'm not sure if there's a better option here. The issue here is just that some of our tests are written incorrectly as they assert on a behavior which was never guaranteed and which now changed with the xunit update. |
xunit added a new event source that we need to filter out: xunit/xunit#2884
/ba-g test failure in System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds is unrelated |
This pull request updates the following dependencies
From https://github.com/dotnet/arcade