Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdac] Implement ISOSDacInterface.GetThreadData #103324

Merged
merged 9 commits into from
Jun 18, 2024
Merged

[cdac] Implement ISOSDacInterface.GetThreadData #103324

merged 9 commits into from
Jun 18, 2024

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Jun 11, 2024 •
edited
Loading

  • Implement GetThreadData in Thread contract
  • Finish implementing ISOSDacInterface::GetThreadData in cDAC
  • Add ExceptionInfo to cDAC types
    • Slight weirdness here around FEATURE_EH_FUNCLETS (only not defined for win x86) - different classes, thread exception state has a pointer or just the ExInfo directly

Contributes to #99298

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

This was referenced Jun 12, 2024
Closed
Closed
Closed
Open
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Jun 13, 2024
Closed
@elinor-fung elinor-fung mentioned this pull request Jun 13, 2024
Open
25 tasks
@build-analysis build-analysis bot mentioned this pull request Jun 14, 2024
Closed
This was referenced Jun 14, 2024
Closed
Open
Open
Open
Open
@build-analysis build-analysis bot mentioned this pull request Jun 14, 2024
Closed
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkotas jkotas closed this Jun 17, 2024
@jkotas jkotas reopened this Jun 17, 2024
This was referenced Jun 18, 2024
Open
Open
Closed
@elinor-fung
Copy link
Member Author

elinor-fung commented Jun 18, 2024 •
edited
Loading

/ba-g non-auto-linked failure is #103642

@elinor-fung elinor-fung merged commit 547e69e into dotnet:main Jun 18, 2024
146 of 151 checks passed
@elinor-fung elinor-fung deleted the cdac-thread branch June 18, 2024 17:00
@jkotas jkotas mentioned this pull request Jun 18, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikem8361 mikem8361 mikem8361 left review comments

@jkotas jkotas jkotas left review comments

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@davidwrighton davidwrighton Awaiting requested review from davidwrighton

@lambdageek lambdageek Awaiting requested review from lambdageek

Assignees

@elinor-fung elinor-fung

Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@elinor-fung @lambdageek @jkotas @mikem8361 @davidwrighton @AaronRobinsonMSFT