-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK to 9.0 Preview 5 #103332
Update SDK to 9.0 Preview 5 #103332
Conversation
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Failures in the WASM legs. Not sure where the WASM legs are getting a 9.0.0-preview.5.24272.2 version of the runtime, I don't see such reference anywhere.
|
@MichalStrehovsky we use Line 257 in f6dc71b
It turns out that that version of the SDK has Since the version is lower it fails. A newer runtime version flowed into the SDK in the meantime so another flow from SDK into runtime should fix this. I triggered the subscription, watch #103195 |
If I understand this correctly this sounds like a cyclic dependency. Can we avoid this by specifying the available runtime version / SDK when invoking that component? |
I'm not sure how, we build WasmAppHost.dll with the sdk from global.json so it embeds the runtime version into .runtimeconfig.json and then we run it on a different sdk which doesn't have that version. I don't think it's a big deal since normally there is some time before we bump the sdk in global.json so the flow would've already happened. Eventually we want to move these tests into the VMR anyway since it's much easier to test end-to-end there. |
|
Ok, that'd work but we'd need to know the version of the shared framework which is a bit cumbersome to get (we'd need to look into what is bundled in the SDK) and might introduce other hard to diagnose failures. I still think we can live with it currently. |
I think we had a bad interaction between #103332 and #103273. Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
I think we had a bad interaction between #103332 and #103273. Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
No description provided.