Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to 9.0 Preview 5 #103332

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Update SDK to 9.0 Preview 5 #103332

merged 2 commits into from
Jun 13, 2024

Conversation

MichalStrehovsky
Copy link
Member

No description provided.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Copy link
Member Author

Failures in the WASM legs. Not sure where the WASM legs are getting a 9.0.0-preview.5.24272.2 version of the runtime, I don't see such reference anywhere.

  Discovered:  Wasi.Build.Tests (found 1 of 12 test case)
  Starting:    Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
    Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
    Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
       Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
      Standard Output:
      [Release_tg0m0nmq_ivw] You must install or update .NET to run this application.
      [Release_tg0m0nmq_ivw] 
      [Release_tg0m0nmq_ivw] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
      [Release_tg0m0nmq_ivw] Architecture: x64
      [Release_tg0m0nmq_ivw] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.5.24306.7' (x64)
      [Release_tg0m0nmq_ivw] .NET location: /root/helix/work/workitem/e/dotnet-latest/
      [Release_tg0m0nmq_ivw] 
      [Release_tg0m0nmq_ivw] The following frameworks were found:
      [Release_tg0m0nmq_ivw]   8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
      [Release_tg0m0nmq_ivw]   9.0.0-preview.5.24272.2 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
      [Release_tg0m0nmq_ivw] 
      [Release_tg0m0nmq_ivw] Learn more:
      [Release_tg0m0nmq_ivw] https://aka.ms/dotnet/app-launch-failed
      [Release_tg0m0nmq_ivw] 
      [Release_tg0m0nmq_ivw] To install missing framework, download:
      [Release_tg0m0nmq_ivw] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.5.24306.7&arch=x64&rid=linux-x64&os=ubuntu.22.04

@akoeplinger
Copy link
Member

akoeplinger commented Jun 12, 2024

@MichalStrehovsky we use SdkVersionForWorkloadTesting to install an SDK for the Wasm.BuildTests, which is currently set to 9.0.100-preview.6.24277.1

<SdkVersionForWorkloadTesting>$(MicrosoftDotNetApiCompatTaskVersion)</SdkVersionForWorkloadTesting>

It turns out that that version of the SDK has 9.0.0-preview.5.24272.2 of the runtime: https://github.com/dotnet/sdk/blob/29b15d1fca51ca7f1d4db87c2b15e39dcaf7bb53/eng/Version.Details.xml#L18-L21

Since the version is lower it fails. A newer runtime version flowed into the SDK in the meantime so another flow from SDK into runtime should fix this. I triggered the subscription, watch #103195

@ViktorHofer
Copy link
Member

If I understand this correctly this sounds like a cyclic dependency. Can we avoid this by specifying the available runtime version / SDK when invoking that component?

@akoeplinger
Copy link
Member

I'm not sure how, we build WasmAppHost.dll with the sdk from global.json so it embeds the runtime version into .runtimeconfig.json and then we run it on a different sdk which doesn't have that version.

I don't think it's a big deal since normally there is some time before we bump the sdk in global.json so the flow would've already happened. Eventually we want to move these tests into the VMR anyway since it's much easier to test end-to-end there.

@ViktorHofer
Copy link
Member

dotnet exec --fx-version ... <-- Version of the installed Shared Framework to use to run the application.

@akoeplinger
Copy link
Member

akoeplinger commented Jun 12, 2024

Ok, that'd work but we'd need to know the version of the shared framework which is a bit cumbersome to get (we'd need to look into what is bundled in the SDK) and might introduce other hard to diagnose failures. I still think we can live with it currently.

lewing pushed a commit that referenced this pull request Jun 13, 2024
I think we had a bad interaction between #103332 and #103273.

Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants