-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LoongArch64-mono] Part-5:Add loongarch support in some files for LoongArch64 #103398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngArch64 Change-Id: I52c8c227fdeeee840cad14496e24e93a04521143
lawn123
requested review from
lambdageek,
steveisok,
BrzVlad,
thaystg and
marek-safar
as code owners
June 13, 2024 07:11
dotnet-policy-service
bot
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Jun 13, 2024
am11
reviewed
Jun 13, 2024
@@ -392,6 +392,8 @@ elseif(CMAKE_SYSTEM_PROCESSOR STREQUAL "i686" OR CMAKE_SYSTEM_PROCESSOR STREQUAL | |||
set(CMAKE_SYSTEM_PROCESSOR "x86") | |||
elseif(CMAKE_SYSTEM_PROCESSOR STREQUAL "aarch64" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "ARM64") | |||
set(CMAKE_SYSTEM_PROCESSOR "arm64") | |||
elseif(CMAKE_SYSTEM_PROCESSOR STREQUAL "loongarch64" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "LOONGARCH64") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add
Lines 457 to 461 in 4f9cd4d
<!-- riscv64 Linux cross build options --> | |
<ItemGroup Condition="'$(MonoCrossDir)' != '' and '$(TargetArchitecture)' == 'riscv64'"> | |
<_MonoCMakeArgs Include="-DCMAKE_TOOLCHAIN_FILE=$(CrossToolchainFile)" /> | |
<_MonoBuildEnv Include="TARGET_BUILD_ARCH=riscv64" /> | |
</ItemGroup> |
am11
reviewed
Jun 13, 2024
am11
reviewed
Jun 13, 2024
am11
reviewed
Jun 13, 2024
am11
reviewed
Jun 13, 2024
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Change-Id: I516967ba6b5a9a973bd6a8b8f1b719ac239ce2db
@am11 Thank you very much. I have added the code you suggested to this PR. |
This was referenced Jun 13, 2024
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
arch-loongarch64
area-Build-mono
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new archecture LoongArch64 for mono.This PR is about loongarch support in some files.