Delete some unused cmake defines #103441
Delete some unused cmake defines #103441
Conversation
am11
requested review from
janvorli,
AaronRobinsonMSFT,
a team and
marek-safar
as code owners
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
| @@ -234,12 +234,9 @@ if(HOST_WIN32) | |||
| # Dynamic lookup using ac_check_headers/ac_check_functions is extremly slow on Windows, espacially on msbuild. | |||
| # Since majority of the checks above will fail on Windows host, we can just directly define the available static | |||
| # API surface. | |||
| set(HAVE_ATEXIT 1) | |||
There was a problem hiding this comment.
I think we need this and perhaps the others. Is that correct, @lateralusX ?
There was a problem hiding this comment.
These are unused. When we need them lets add them then.
There was a problem hiding this comment.
In dotnet/runtime perhaps, but they may be used in forks. If that's the case, I'd rather keep it.
There was a problem hiding this comment.
Can you point me to the fork you are referring to? The dead code is deleted in this repo. If fork is using it, it should be kept there.
There was a problem hiding this comment.
It's non-public, unfortunately. I want to make sure it's even used there first. If it's not, then my comment is moot.
There was a problem hiding this comment.
Not used so should be fine dropping and if ever needed in future we add it downstream.
Found with: