Pass RID to msbuild task #103508
Merged
Pass RID to msbuild task #103508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
am11
added
area-Infrastructure
and removed
area-Infrastructure-libraries
community-contribution
|
@MichalStrehovsky, I was able to repro it locally (with command from #103469 (comment)). |
…03273)" (dotnet#103497)" This reverts commit 7e9cab2.
am11
changed the title
This was referenced Jun 15, 2024
|
Thanks! I'll test this out by doing an official build from a branch once the infra is stable enough, but for now marking no merge. @jkoritzinsky could you please have a look at the ddf4666 commit? The rest was already reviewed and is a revert of a revert. |
MichalStrehovsky
added
the
NO-MERGE
|
runtime builds are now flowing normally through the SDK. No rush, but would be good to avoid conflicts if we can, as testing it requires spending time on multiple VMs / containers (and at some point I'd like to restart my computer 😅). |
jkoritzinsky
approved these changes
Jun 24, 2024
|
/ba-g binaryformatter CI issues were fixed in the meantime and is unrelated |
MichalStrehovsky
removed
the
NO-MERGE
|
Thank you! I'll watch the official builds... |
|
Picked up in dotnet/sdk#41793. 🙏 |
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Jun 27, 2024
This reverts commit 4e1ad9c.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is reverting #103497, second commit has the fix for official build.