Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] [HybridGlobalization]Pass non-breaking space / narrow non-breaking space characters #103647

Conversation

mkhamoyan
Copy link
Contributor

Description

Backport of #103226 to release/8.0-staging

Customer Impact

Customer reported when using hybrid globalization on iOS and using the short time specifier, there is no space in front of the "AM" or "PM".

Regression

  • Yes
  • No

Testing

Tests were added to the original PR.

Risk

Affects Globalization code on Apple mobile scenario when HybridGlobalization is enabled.

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-extra-platforms

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan mkhamoyan marked this pull request as ready for review June 20, 2024 10:56
@mkhamoyan mkhamoyan added Servicing-consider Issue for next servicing release review Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 24, 2024
@mkhamoyan
Copy link
Contributor Author

This was approved by tactics over the email.

@mkhamoyan
Copy link
Contributor Author

The failures on runtime-extra-platforms CI are un-related and already present on the other release/8.0-staging runs.

@mkhamoyan mkhamoyan merged commit 4ef94c1 into dotnet:release/8.0-staging Jun 25, 2024
237 of 251 checks passed
@mkhamoyan mkhamoyan deleted the backport/pr-103226-to-release/8.0-staging branch June 25, 2024 07:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Globalization os-ios Apple iOS os-maccatalyst MacCatalyst OS os-tvos Apple tvOS Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants