Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align System.CommandLine version with SDK #103759

Closed
wants to merge 1 commit into from

Conversation

am11
Copy link
Member

@am11 am11 commented Jun 20, 2024

cc @ViktorHofer, @akoeplinger for some reason, auto-update is not working in runtime, as in; dotnet/sdk#40075.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 20, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

</Dependency>
<!-- Intermediate is necessary for source build. -->
<Dependency Name="Microsoft.SourceBuild.Intermediate.command-line-api" Version="0.1.440701">
Copy link
Member Author

@am11 am11 Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still necessary for source build? There is a separate (newer) version for source-build in the SDK repo as well: https://github.com/dotnet/sdk/blob/d0ccce00860ffdee00d7328705e841e4f785a999/src/SourceBuild/content/eng/Versions.props#L29

@ViktorHofer
Copy link
Member

Yes we still need this for source-build. We should investigate why dependency flow doesn't work.

@am11
Copy link
Member Author

am11 commented Jun 20, 2024

I think it's the only one using libraries feed

<add key="dotnet-libraries" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries/nuget/v3/index.json" />
and it's probably not configured in code flow?

What I understood from @adamsitnik is that they should be kept in sync across dotnet repos (dotnet/command-line-api#2146), so probably configuring auto-update (like dotnet/sdk has) is the right solution.

@ViktorHofer
Copy link
Member

The subscription was disabled for main. I just enabled.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 20, 2024

The update is now part of #103574. Let's close this PR. Thanks for bringing this up :)

@am11
Copy link
Member Author

am11 commented Jun 20, 2024

Awesome! 👍

@adamsitnik
Copy link
Member

What I understood from @adamsitnik is that they should be kept in sync across dotnet repos

Correct.

We should investigate why dependency flow doesn't work.

I've not been involved in System.CommandLine for almost a year now, but my understanding was that S.CL publishes a new package after every PR gets merged and at that time we were introducing a lot of breaking changes and did want to address each of them separately in every repo. We wanted to do that on demand, when something that was merged was needed.

But this could have changed since then @baronfel @jonsequitur

@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants