JIT: Specialize fgFindJumpTargets
#103761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This specializes `fgFindJumpTargets` based on whether we are making inline observations or not. This function has a lot of conditional logic based on this property, but it is always going to be false in MinOpts, so this allows the native compiler to optimize the function much better (and avoids all the conditionals). Using the VS profiler shows that the relative CPU time spent in the function goes from 0.98% to 0.47% for the MinOpts contexts in benchmarks.run_pgo.windows.x64.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
Heh, I remember I tried the same, but the savings were too small so I didn't bother, let's see what you will get 🙂 |
EgorBo
approved these changes
Jun 20, 2024
This was referenced Jun 20, 2024
|
/ba-g Failures are timeouts on Linux-x64 due to slow Helix queues |
rzikm
pushed a commit
to rzikm/dotnet-runtime
that referenced
this pull request
Jun 24, 2024
This specializes `fgFindJumpTargets` based on whether we are making inline observations or not. This function has a lot of conditional logic based on this property, but it is always going to be false in MinOpts, so this allows the native compiler to optimize the function much better (and avoids all the conditionals). Using the VS profiler shows that the relative CPU time spent in the function goes from 0.98% to 0.47% for the MinOpts contexts in benchmarks.run_pgo.windows.x64.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specializes
fgFindJumpTargetsbased on whether we are making inline observations or not. This function has a lot of conditional logic based on this property, but it is always going to be false in MinOpts, so this allows the native compiler to optimize the function much better (and avoids all the conditionals).Using the VS profiler shows that the relative CPU time spent in the function goes from 0.98% to 0.47% for the MinOpts contexts in benchmarks.run_pgo.windows.x64.
This should pay off the TP cost of #103537.