Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoongArch64] Fix build error for LA64. #103792

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

LuckyXu-HF
Copy link
Contributor

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 21, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 21, 2024
@LuckyXu-HF
Copy link
Contributor Author

This is a nit within PR #103690.
@jakobbotsch @shushanhf could you please review this PR? Thank you.

@huoyaoyuan
Copy link
Member

Looks like a simple typo during replacing in the original PR.
Can we set up some basic cross build to help validating these?

@LuckyXu-HF
Copy link
Contributor Author

LuckyXu-HF commented Jun 21, 2024

Looks like a simple typo during replacing in the original PR. Can we set up some basic cross build to help validating these?

It might take a little more time. But as far as I know LoongArch has already supported the Alpine. I believe that we can set up a simple verification environment for LA64 first in the nearly future.

@am11
Copy link
Member

am11 commented Jun 21, 2024

@LuckyXu-HF lets do it once this is in: dotnet/arcade#14849 (I'm running the final tests dotnet/dotnet-buildtools-prereqs-docker#1102).

@am11
Copy link
Member

am11 commented Jun 21, 2024

@LuckyXu-HF, LA64 is not showing up https://pkgs.alpinelinux.org/packages, is there a separate feed for it? We can support it in that case, but it will require a bit of customization (but doable).

@LuckyXu-HF
Copy link
Contributor Author

LuckyXu-HF commented Jun 21, 2024

@LuckyXu-HF, LA64 is not showing up https://pkgs.alpinelinux.org/packages,

Hi @am11 @huoyaoyuan , thanks very much for reply. Yes, the official Alpine support for LA64 is WIP now. So LA64 is not showing up within https://pkgs.alpinelinux.org/packages

is there a separate feed for it? We can support it in that case, but it will require a bit of customization (but doable).

Yes, you can fetch the Apline-LA64 with this url: https://dev.alpinelinux.org/~loongarch/edge/
But please pay a special attention that this source is just for temporary test only, if there exist any issues we will need to wait a bit longer. :)

  • After asking my colleagues, this source(https://dev.alpinelinux.org/~loongarch/edge/) will keep updating with the Apline-upstream, and maybe update 1~2 times per week, until the Alpine-upstream merged LA64 or the official source provide a available source for LA64.
  • The build for LA64-coreclr on Alpine-LA64 will need an additional patch, which I have verified successfully last week locally.

@am11
Copy link
Member

am11 commented Jun 21, 2024

Great! 👍 I think we can manage it. I will try to get its key (we are doing secure package downloads on Alpine and Debian), to fit it into our infra. Otherwise skipping the key is also an option. I'll ping in PR once I've something working.

@LuckyXu-HF
Copy link
Contributor Author

Great! 👍 I think we can manage it. I will try to get its key (we are doing secure package downloads on Alpine and Debian), to fit it into our infra. Otherwise skipping the key is also an option. I'll ping in PR once I've something working.

Thanks very much!

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry about the break.

@jakobbotsch jakobbotsch merged commit 7c4b4bb into dotnet:main Jun 21, 2024
105 of 107 checks passed
@LuckyXu-HF LuckyXu-HF deleted the main-LA64 branch June 24, 2024 01:04
rzikm pushed a commit to rzikm/dotnet-runtime that referenced this pull request Jun 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants