-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Handle TYP_DOUBLE on arm softFP similarly to TYP_LONG #103869
JIT: Handle TYP_DOUBLE on arm softFP similarly to TYP_LONG #103869
Conversation
Avoids `PUTARG_REG` being a multi-reg node on arm32 to handle this special case.
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
cc @dotnet/jit-contrib PTAL @dotnet/samsung @kunalspathak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the cleanup. LGTM, shouldn't affect RISC-V.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
+ Checked coreclr test on armel tizen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Avoids
PUTARG_REG
being a multi-reg node on arm32 to handle this special case.The gist of the change: we expect multi-reg structs, including
TYP_LONG
on arm32/x86, to be put into aFIELD_LIST(PUTARG_REG(low), PUTARG_REG(high))
form before LSRA. For multi-reg structs this happens during morph, while forTYP_LONG
we keep them as primitives until lowering, so it happens during lowering.There was a special case for arm32 with softFP where
TYP_DOUBLE
also ends up being a similar multi-reg struct that is passed in two integer registers. There was a bunch of special casing to handle this in the backend, by makingPUTARG_REG
andBITCAST
multireg nodes on arm32 only.This PR instead puts
TYP_DOUBLE
into the expected multireg-struct form during lowering, allowing it to be handled like any other multireg struct.Motivation is to avoid arm32-specific logic in #103866, which currently fails in CI for arm32 softFP because of this special case.