Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax threshold in GC Regressions test #103898

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Relax threshold in GC Regressions test #103898

merged 1 commit into from
Jun 24, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jun 24, 2024

Fixes #103494

@jkotas
Copy link
Member Author

jkotas commented Jun 24, 2024

The test expects less than 50 full GC, but it has been going over this threshold recently. For example, https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-103308-merge-646fbe4a4e9e472bad/PayloadGroup0/1/Reports/GC.Regressions/v2.0-beta2/452950/452950/452950.output.txt?helixlogtype=result shows a test run that hit 53 full GCs.

@jkotas jkotas requested review from mangod9 June 24, 2024 13:57
@jkotas jkotas requested review from cshung June 24, 2024 13:58
Copy link
Contributor

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@mangod9 mangod9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing.

@jkotas jkotas merged commit 8d6e07d into dotnet:main Jun 24, 2024
69 checks passed
@jkotas jkotas deleted the fix-452950 branch June 24, 2024 17:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GC/Regressions/v2.0-beta2/452950 failed in CI
2 participants