Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup certificates before running ConnectWithRevocation_WithCallback_Core on Windows #104014

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Jun 26, 2024

Attempt to fix #101835.

Looking at other usages of BuildPrivatePki on Windows, this is the only difference I see, and other tests seem to pass without problems.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@rzikm
Copy link
Member Author

rzikm commented Jun 26, 2024

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rzikm
Copy link
Member Author

rzikm commented Jun 26, 2024

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rzikm rzikm added the NO-REVIEW Experimental/testing PR, do NOT review it label Jun 26, 2024
@rzikm rzikm removed the NO-REVIEW Experimental/testing PR, do NOT review it label Jun 26, 2024
@rzikm
Copy link
Member Author

rzikm commented Jun 26, 2024

The test in question did not fail on CI, I suggest we try to merge this and see if the failures disappear.

@rzikm rzikm requested review from wfurt and liveans June 26, 2024 14:58
@rzikm rzikm merged commit 9317db0 into dotnet:main Jun 26, 2024
115 of 143 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
@karelz karelz added this to the 9.0.0 milestone Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants