Improve JsonNode.DeepEquals numeric equality.
#104255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
eiriktsarpalis
commented
Jul 1, 2024
src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonElement.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 1, 2024
There was a problem hiding this comment.
Implementation-wise, LGTM. I defer to @tannergooding about appropriateness.
|
Relates to #97490 |
stephentoub
reviewed
Jul 2, 2024
stephentoub
reviewed
Jul 2, 2024
stephentoub
reviewed
Jul 2, 2024
stephentoub
reviewed
Jul 2, 2024
src/libraries/System.Text.Json/src/System/Text/Json/JsonHelpers.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 2, 2024
src/libraries/System.Text.Json/src/System/Text/Json/JsonHelpers.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 2, 2024
src/libraries/System.Text.Json/src/System/Text/Json/JsonHelpers.cs
Outdated
Show resolved
Hide resolved
…s.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
eiriktsarpalis
changed the title
JsonNode.DeepEquals numeric equality.JsonNode.DeepEquals numeric equality.
eiriktsarpalis
commented
Jul 2, 2024
src/libraries/System.Text.Json/src/System/Text/Json/JsonHelpers.cs
Outdated
Show resolved
Hide resolved
|
@tannergooding would it be possible to take another look at this? |
3 tasks
stephentoub
reviewed
Jul 8, 2024
stephentoub
approved these changes
Jul 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JsonNode.DeepEqualsimplementation currently uses UTF-8 sequence equality when determining if two JSON numbers are equal. This means that under the current semantics1.0!=1and-0.0!=0.Following feedback from @gregsdennis I put up this PR that attempts to derive numeric equality from
decimal. This approach has its own share of problems though because we currently have no way of handling numeric values not representable bydecimal, so it still needs to fallback to sequence equality (aBigDecimaltype might have been useful in this case).Fix #97490.