[main] Update dependencies from dotnet/roslyn

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

• Subscription: 037eb78c-9902-4cb9-856d-08db8ed7cafd
• Build: 20240705.3
• Date Produced: July 6, 2024 2:34:31 AM UTC
• Commit: 19b5e961ecb97b008106f1b646c077e0bffde4a7
• Branch: refs/heads/main

• Updates:
  • Microsoft.SourceBuild.Intermediate.roslyn: from 4.11.0-3.24329.1 to 4.12.0-1.24355.3
  • Microsoft.CodeAnalysis: from 4.11.0-3.24329.1 to 4.12.0-1.24355.3
  • Microsoft.CodeAnalysis.CSharp: from 4.11.0-3.24329.1 to 4.12.0-1.24355.3
  • Microsoft.Net.Compilers.Toolset: from 4.11.0-3.24329.1 to 4.12.0-1.24355.3

[ViktorHofer]

The subscriptions points to dev17.11 not dev17.12. This has happened multiple times now and I would like to understand how to avoid this going forward. cc @jaredpar @jjonescz

Updating the subscription now.

[jjonescz]

I was told it's the responsibility of each repository to keep its incoming subscriptions correct. But honestly, I think when we update the default channels in roslyn we could easily update the subscriptions to runtime and SDK as well (not sure if there are others subscribing to roslyn). Or we could ping someone if you prefer that.

Note that there is a checklist we follow so this needs to be added to it.

[ViktorHofer]

Runtime wants to reference the latest roslyn during previews, that's why we only have a subscription to it in our main branch. The intent here is to use the latest compiler for new language features. Roslyn updates the channel every couple of months (I believe every 3 months?) but we have no indication that the channel changed.

So yes, it would great if updating the subscription channel for at least runtime would be part of updating the channel in roslyn.

[jaredpar]

I was told it's the responsibility of each repository to keep its incoming subscriptions correct.

That is correct.

I think when we update the default channels in roslyn we could easily update the subscriptions to runtime and SDK as well (not sure if there are others subscribing to roslyn)

This is how we used to do things but abandoned it because it's not workable over a long scale. Each repo has different branching policy, subscription policies, etc ... Having every repo (roslyn, fsharp, msbuild, etc ...) be responsible for updating runtime, sdk, etc ... one every sub change just does not scale. Also the work inevitably gets lost and there is confusion on who is responsible for making what changes.

We decided on the current system because it minimizes communication between teams and removes responsibility confusion.

Roslyn updates the channel every couple of months (I believe every 3 months?) but we have no indication that the channel changed.

Yes it's roughly every three months because that is how often Visual Studio ships.

Happy to consider a better way of broadcasting that we're updating the subs but don't want responsibility for updating the runtime repo

[ViktorHofer]

Happy to consider a better way of broadcasting that we're updating the subs but don't want responsibility for updating the runtime repo

A mail to runtimerepoinfra would be great. We will then just invoke the following command ourselves:

darc update-subscription --id 037eb78c-9902-4cb9-856d-08db8ed7cafd --channel "VS 17.12"

[jaredpar]

A mail to runtimerepoinfra would be great. We will then just invoke the following command ourselves:

Don't want to email specific teams. Do we have a general place we can broadcast darc changes?

[ViktorHofer]

What about the "Code-velocity chat"? We would still need a ping so that we don't miss it.

[jaredpar]

What about the "Code-velocity chat"? We would still need a ping so that we don't miss it

Code-velocity chat is a private chat. Only people in the chat have access to it. Arbitrary people cannot step into the chat and write messages.

Let my try explaining that problem a different way. We have lots of docs for our infra team describing all the steps they need to take when starting a release. How would we describe posting a message to the Code-Velocity chat? All we can say is go post a message in a chat with this name. There is no link we can provide that redirects to the chat. Best we can do is say "email jared and see if he can add you". If Code-Velocity chat were say a channel in a team then we could post a link that was actionable.

[ViktorHofer]

Makes sense and I'm absolutely fine with any option. What's your idea?

[jaredpar]

Think we should consider moving code velocity to a real channel.