Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove virtual modifier from GetDatePart #104456

Merged
merged 2 commits into from
Jul 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ internal static int GetLunarMonthDay(int gregorianYear, DateBuffer lunarDate)
/// Returns a given date part of this DateTime. This method is used
/// to compute the year, day-of-year, month, or day part.
/// </summary>
internal virtual int GetDatePart(long ticks, int part)
private static int GetDatePart(long ticks, int part)
{
// The Gregorian year, month, day value for ticks.
int hebrewYearType; // lunar year type
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ internal static void CheckYearMonthRange(int year, int month, int era)
/// In order to get the exact Hijri year, we compare the exact absolute date for HijriYear and (HijriYear + 1).
/// From here, we can get the correct Hijri year.
/// </summary>
internal virtual int GetDatePart(long ticks, int part)
private int GetDatePart(long ticks, int part)
{
CheckTicksRange(ticks);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ internal static void CheckDayRange(int year, int month, int day)
/// Returns a given date part of this DateTime. This method is used
/// to compute the year, day-of-year, month, or day part.
/// </summary>
internal static int GetDatePart(long ticks, int part)
private static int GetDatePart(long ticks, int part)
{
// Gregorian 1/1/0001 is Julian 1/3/0001. Remember DateTime(0) is referred to Gregorian 1/1/0001.
// The following line convert Gregorian ticks to Julian ticks.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ private static int DaysInPreviousMonths(int month)
return DaysToMonth[month];
}

internal int GetDatePart(long ticks, int part)
private int GetDatePart(long ticks, int part)
{
CheckTicksRange(ticks);

Expand Down
Loading