Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frame boundary detection in SslStream #104606

Merged
merged 5 commits into from
Jul 11, 2024
Merged

Fix frame boundary detection in SslStream #104606

merged 5 commits into from
Jul 11, 2024

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Jul 9, 2024 •
edited
Loading

Fixes #104605.
Fixes #104682.

@rzikm rzikm added the NO-REVIEW Experimental/testing PR, do NOT review it label Jul 9, 2024
@rzikm rzikm added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 9, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@rzikm rzikm changed the title System.Net.Security.Tests.SslStreamNetworkStreamTest.SslStream_RandomSizeWrites_OK investigation PR [NOREVIEW] System.Net.Security.Tests.SslStreamNetworkStreamTest.SslStream_RandomSizeWrites_OK investigation PR Jul 9, 2024
This was referenced Jul 9, 2024
Open
Closed
Open
Closed
Open
@rzikm rzikm force-pushed the 104605-Test-Failure-SystemNetSecurityTestsSslStreamNetworkStreamTestSslStream_RandomSizeWrites_OK branch from 59a7ac6 to 3d7fd83 Compare July 10, 2024 16:11
@rzikm rzikm removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Jul 10, 2024
@rzikm rzikm requested a review from a team July 10, 2024 16:14
@rzikm rzikm changed the title [NOREVIEW] System.Net.Security.Tests.SslStreamNetworkStreamTest.SslStream_RandomSizeWrites_OK investigation PR Fix frame boundary detection in SslStream Jul 10, 2024
This was referenced Jul 10, 2024
Closed
Closed
Closed
wfurt
wfurt approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzikm rzikm merged commit 0d426df into dotnet:main Jul 11, 2024
74 of 83 checks passed
@rzikm rzikm mentioned this pull request Jul 11, 2024
Merged
@mdh1418 mdh1418 mentioned this pull request Jul 11, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2024
@karelz karelz added this to the 9.0.0 milestone Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liveans liveans liveans approved these changes

@wfurt wfurt wfurt approved these changes

Assignees

@rzikm rzikm

Labels
area-System.Net.Security
Projects
None yet
Milestone
9.0.0
4 participants
@rzikm @wfurt @liveans @karelz