-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toolchain instructions for Fedora #104859
Conversation
Tagging subscribers to this area: @dotnet/area-meta |
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* ninja-build (optional, enables building native code with ninja instead of make) | ||
|
||
```bash | ||
sudo dnf install -y cmake llvm lld lldb clang python curl git libicu-devel openssl-devel \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add it in install script as well while at it: am11@500300e (in the script, we assume git was already installed, since user cloned the repo, and ninja is optional; least required deps doesn't hurt to add them as you see fit 🙂)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. @am11 Would you like to submit a PR?
(Also, zlib-devel
should not be needed anymore - for both Debian and Fedora.)
Fedora-based distributions use a different convention for package names, and differ enough from Debian-systems that I always need to go back to my notes to remember the exact names of build dependencies for Fedora.
/cc @tmds and @omajid for any feedback.