Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolchain instructions for Fedora #104859

Merged
merged 5 commits into from
Jul 13, 2024
Merged

Conversation

vcsjones
Copy link
Member

Fedora-based distributions use a different convention for package names, and differ enough from Debian-systems that I always need to go back to my notes to remember the exact names of build dependencies for Fedora.

/cc @tmds and @omajid for any feedback.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkotas jkotas merged commit 74af205 into dotnet:main Jul 13, 2024
12 checks passed
@vcsjones vcsjones deleted the fedora-build-docs branch July 13, 2024 17:15
* ninja-build (optional, enables building native code with ninja instead of make)

```bash
sudo dnf install -y cmake llvm lld lldb clang python curl git libicu-devel openssl-devel \
Copy link
Member

@am11 am11 Jul 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add it in install script as well while at it: am11@500300e (in the script, we assume git was already installed, since user cloned the repo, and ninja is optional; least required deps doesn't hurt to add them as you see fit 🙂)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. @am11 Would you like to submit a PR?

(Also, zlib-devel should not be needed anymore - for both Debian and Fedora.)

@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants