-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Avoid duplicate hash table lookups in VN #104873
JIT: Avoid duplicate hash table lookups in VN #104873
Conversation
We can switch to recently added `LookupPointerOrAdd` to avoid duplicate hash table lookups for the `VNForFunc` family of functions.
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
/azp run runtime-coreclr superpmi-replay |
Azure Pipelines successfully started running 1 pipeline(s). |
Detailed tp diff on linux which has TP regressions:
This just looks like missed inlining, probably related to link-time codegen not being enabled in our TP runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering - is it possible to post "Detailed tp diff" on CI? could be on-demand
Sure, it would be nice to have something like that. Ideally we would add support for parallelism and automatically filtering out TP from misses if we were to add it into CI. |
We can switch to recently added
LookupPointerOrAdd
to avoid duplicate hash table lookups for theVNForFunc
family of functions.