Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging][browser] Fix WBT timeout (30000ms exceeded) #104947

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

ilonatommy
Copy link
Member

Backport of #104481.

Fixes #104830.

Risk:
Low
This PR changes only the test infrastructure. Instead of trying to launch browser once for 3s, with this PR we try 3 times, 1s each.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-VM-meta-mono os-browser Browser variant of arch-wasm labels Jul 16, 2024
@ilonatommy ilonatommy requested review from carlossanlop and maraf July 16, 2024 08:31
@ilonatommy ilonatommy self-assigned this Jul 16, 2024
@ilonatommy ilonatommy requested a review from radical as a code owner July 16, 2024 08:31
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@ilonatommy ilonatommy added test-enhancement Improvements of test source code Servicing-consider Issue for next servicing release review labels Jul 16, 2024
@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@ilonatommy
Copy link
Member Author

ilonatommy commented Jul 16, 2024

Aren't WasmBuildTests on browser running on CI in net8? How can I test them?

Regardless of azure-pipelines response above, it got triggered.

@ilonatommy ilonatommy added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 16, 2024
@ilonatommy ilonatommy merged commit a28aa7d into release/8.0-staging Jul 16, 2024
25 of 26 checks passed
@jkotas jkotas deleted the backport-104481 branch July 27, 2024 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants