[cdac] Pass a delegate into Target #105043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, the Target type in cdacreader takes an unmanaged function pointer and a context object to enable reading from target memory. This works well for the current implementation, where cdacreader is an implementation detail of the C++ DAC. However, this is more difficult for scenarios where the "reader" is also in managed code, as whatever the "context" object represents must be converted into an unmanaged function pointer. For the StressLogAnalyzer (#104999), it was relatively easy to represent the context object as a pointer. However, this is more difficult in scenarios like SOS's managed component, where the functionality to access memory is provided by a service object that's injected by a DI/IOC container.
To simplify managed-only usage scenarios, take a delegate instead of taking an unmanaged function pointer when constructing a
Target
object.