Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Skip moving BBJ_COND jump target if fallthrough target is equally likely #105084

Merged
merged 1 commit into from
Jul 18, 2024

Don't move conditional jump target if equally likely

9b49d77
Select commit
Loading
Failed to load commit list.
Merged

JIT: Skip moving BBJ_COND jump target if fallthrough target is equally likely #105084

Don't move conditional jump target if equally likely
9b49d77
Select commit
Loading
Failed to load commit list.
Azure Pipelines / runtime failed Jul 18, 2024 in 1h 39m 47s

Build #20240718.42 had test failures

Details

Tests

  • Failed: 9 (0.00%)
  • Passed: 1,250,661 (98.36%)
  • Other: 20,855 (1.64%)
  • Total: 1,271,525

Annotations

Check failure on line 91 in .packages\microsoft.dotnet.helix.sdk\9.0.0-beta.24360.4\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

.packages\microsoft.dotnet.helix.sdk\9.0.0-beta.24360.4\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets#L91

.packages\microsoft.dotnet.helix.sdk\9.0.0-beta.24360.4\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(91,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item nativeaot.SmokeTests in job 72586a7a-5038-47e4-9609-7182853cd0d3 has failed.
Failure log: https://helix.dot.net/api/2019-06-17/jobs/72586a7a-5038-47e4-9609-7182853cd0d3/workitems/nativeaot.SmokeTests/console

Check failure on line 91 in .packages\microsoft.dotnet.helix.sdk\9.0.0-beta.24360.4\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

.packages\microsoft.dotnet.helix.sdk\9.0.0-beta.24360.4\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets#L91

.packages\microsoft.dotnet.helix.sdk\9.0.0-beta.24360.4\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(91,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item System.Reflection.Tests in job a68242fb-21af-4eb8-8562-396b8f2432a7 has failed.
Failure log: https://helix.dot.net/api/2019-06-17/jobs/a68242fb-21af-4eb8-8562-396b8f2432a7/workitems/System.Reflection.Tests/console

Check failure on line 1 in nativeaot\\SmokeTests\\Reflection\\Reflection_FromUsage\\Reflection_FromUsage.cmd

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

nativeaot\\SmokeTests\\Reflection\\Reflection_FromUsage\\Reflection_FromUsage.cmd

Process terminated. Access Violation: Attempted to read or write protected memory. This is often an indication that other memory is corrupt. The application will be terminated since this platform does not support throwing an AccessViolationException.
   at System.RuntimeExceptionHelpers.FailFast(String message, Exception exception, String errorSource, RhFailFastReason reason, IntPtr pExAddress, IntPtr pExContext) + 0x200
   at System.RuntimeExceptionHelpers.GetRuntimeException(ExceptionIDs id) + 0x148
   at System.Runtime.EH.GetClasslibException(ExceptionIDs id, IntPtr address) + 0x48
   at System.Runtime.EH.RhThrowHwEx(UInt32 exceptionCode, EH.ExInfo& exInfo) + 0xa8
   at Internal.Reflection.Execution.FieldAccessors.ValueTypeFieldAccessorForStaticFields.GetFieldBypassCctor() + 0x68
   at ReflectionTest.TestThreadStaticFields.Run() + 0xfc
   at ReflectionTest.Main() + 0xc0

Return code:      1
Raw output file:      C:\h\w\AF8F092A\w\ADCF0980\uploads\Reports\nativeaot.SmokeTests\Reflection\Reflection_FromUsage\Reflection_FromUsage.output.txt
Raw output:
BEGIN EXECUTION
call C:\h\w\AF8F092A\p\nativeaottest.cmd C:\h\w\AF8F092A\w\ADCF0980\e\nativeaot\SmokeTests\Reflection\Reflection_FromUsage\ Reflection_FromUsage.dll 
Testing delegate targets are reflectable...
Testing virtual delegate targets are reflectable...
TestContainment
TestInterfaceMethod
TestByRefLikeTypeMethod
TestILScanner
Search current assembly
GetMethod on a non-generic type
Totally unreferenced method on a non-generic type (we should not find it)
GetMethod on a non-generic type for a generic method
Generics
Partial canonical types
Search in system assembly
Search through a forwarder
Search in mscorlib
Enum.GetValues
Enum.GetValuesAsUnderlyingType
Pattern in LINQ expressions
Other pattern in LINQ expressions
TestUnreferencedEnum
TestAttributeInheritance
TestStringConstructor
TestAssemblyAndModuleAttributes
TestAttributeExpressions
TestParameterAttributes
TestPropertyAndEventAttributes
TestNecessaryEETypeReflection
False
False
False
False
True
True
True
ReflectionTest+TestGenericLdtoken+Generic`1[[ReflectionTest+TestGenericLdtoken+Atom, Reflection_FromUsage, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null]]
TestCreateDelegate
TestGetUninitializedObject
TestInstanceFields
TestReflectionInvoke
TestConstructors
TestInvokeMemberParamsCornerCase
TestDefaultInterfaceInvoke
TestCovariantReturnInvoke
TestThreadStaticFields
Expected: 100
Actual: -1073740791
END EXECUTION - FAILED
FAILED
Test failed. Trying to see if dump file was created in C:\cores since 7/18/2024 2:48:17 PM
Processing C:\cores\Reflection_FromUsage.exe.7348.dmp
Unable to find cdb.exe at C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\cdb.exe
Test Harness Exitcode is : 1
To run the test:
> set CORE_ROOT=C:\h\w\AF8F092A\p
> C:\h\w\AF8F092A\w\ADCF0980\e\nativeaot\SmokeTests\Reflection\Reflection_FromUsage\Reflection_FromUsage.cmd
Raw output
   at nativeaot_SmokeTests._Reflection_Reflection_FromUsage_Reflection_FromUsage_._Reflection_Reflection_FromUsage_Reflection_FromUsage_cmd() in D:\a\_work\1\s\artifacts\tests\coreclr\windows.arm64.Release\TestWrappers\nativeaot.SmokeTests\nativeaot.SmokeTests.XUnitWrapper.cs:line 1139
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in nativeaot\\SmokeTests\\Reflection\\Reflection\\Reflection.cmd

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

nativeaot\\SmokeTests\\Reflection\\Reflection\\Reflection.cmd

Process terminated. Access Violation: Attempted to read or write protected memory. This is often an indication that other memory is corrupt. The application will be terminated since this platform does not support throwing an AccessViolationException.
   at System.RuntimeExceptionHelpers.FailFast(String, Exception, String, RhFailFastReason, IntPtr, IntPtr) + 0x200
   at System.RuntimeExceptionHelpers.GetRuntimeException(ExceptionIDs) + 0x148
   at System.Runtime.EH.GetClasslibException(ExceptionIDs, IntPtr) + 0x48
   at System.Runtime.EH.RhThrowHwEx(UInt32, EH.ExInfo&) + 0xa8
   at Internal.Reflection.Execution.FieldAccessors.ValueTypeFieldAccessorForStaticFields.GetFieldBypassCctor() + 0x68
   at ReflectionTest.TestThreadStaticFields.Run() + 0xfc
   at ReflectionTest.Main() + 0xcc

Return code:      1
Raw output file:      C:\h\w\AF8F092A\w\ADCF0980\uploads\Reports\nativeaot.SmokeTests\Reflection\Reflection\Reflection.output.txt
Raw output:
BEGIN EXECUTION
call C:\h\w\AF8F092A\p\nativeaottest.cmd C:\h\w\AF8F092A\w\ADCF0980\e\nativeaot\SmokeTests\Reflection\Reflection\ Reflection.dll 
Testing delegate targets are reflectable...
Testing virtual delegate targets are reflectable...
TestContainment
TestInterfaceMethod
TestByRefLikeTypeMethod
TestILScanner
Search current assembly
GetMethod on a non-generic type
Totally unreferenced method on a non-generic type (we should not find it)
GetMethod on a non-generic type for a generic method
Generics
Partial canonical types
Search in system assembly
Search through a forwarder
Search in mscorlib
Enum.GetValues
Enum.GetValuesAsUnderlyingType
Pattern in LINQ expressions
Other pattern in LINQ expressions
TestUnreferencedEnum
TestAttributeInheritance
TestStringConstructor
TestAssemblyAndModuleAttributes
TestAttributeExpressions
TestParameterAttributes
TestPropertyAndEventAttributes
TestNecessaryEETypeReflection
False
False
False
False
True
True
True
ReflectionTest+TestGenericLdtoken+Generic`1[[ReflectionTest+TestGenericLdtoken+Atom, Reflection, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null]]
TestCreateDelegate
TestGetUninitializedObject
TestInstanceFields
TestReflectionInvoke
TestConstructors
TestInvokeMemberParamsCornerCase
TestDefaultInterfaceInvoke
TestCovariantReturnInvoke
TestThreadStaticFields
Expected: 100
Actual: -1073740791
END EXECUTION - FAILED
FAILED
Test failed. Trying to see if dump file was created in C:\cores since 7/18/2024 2:48:22 PM
Processing C:\cores\Reflection.exe.8548.dmp
Unable to find cdb.exe at C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\cdb.exe
Finished looking for *.dmp. No new files created.
Test Harness Exitcode is : 1
To run the test:
> set CORE_ROOT=C:\h\w\AF8F092A\p
> C:\h\w\AF8F092A\w\ADCF0980\e\nativeaot\SmokeTests\Reflection\Reflection\Reflection.cmd
Raw output
   at nativeaot_SmokeTests._Reflection_Reflection_Reflection_._Reflection_Reflection_Reflection_cmd() in D:\a\_work\1\s\artifacts\tests\coreclr\windows.arm64.Release\TestWrappers\nativeaot.SmokeTests\nativeaot.SmokeTests.XUnitWrapper.cs:line 1040
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in System.Reflection.Tests.WorkItemExecution

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

System.Reflection.Tests.WorkItemExecution

The Helix Work Item failed. Often this is due to a test crash. Please see the 'Artifacts' tab above for additional logs.

Check failure on line 1 in nativeaot.SmokeTests.WorkItemExecution

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

nativeaot.SmokeTests.WorkItemExecution

The Helix Work Item failed. Often this is due to a test crash. Please see the 'Artifacts' tab above for additional logs.