-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make System.IO.Packaging test trim safe #105160
Conversation
The existing pattern doesn't get statically analyzed.
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Tagging subscribers to this area: @dotnet/area-system-io |
@MichalStrehovsky For my own education, can you please share the output of the error you were seeing? Or if you had an issue open to track it, even better (there's none in the description).
|
It's a nullreferenceexception since either the GetType or GetMethod returned null. It's visible in #104516. I don't file issues for things like this because it's not worth the hassle. |
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/ba-g The reflection test failure on ARM64 was known and has been fixed since the CI ran. Not going to rerun CI for that. |
The existing pattern doesn't get statically analyzed and is breaking outerloop testing.