Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make System.IO.Packaging test trim safe #105160

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

MichalStrehovsky
Copy link
Member

The existing pattern doesn't get statically analyzed and is breaking outerloop testing.

The existing pattern doesn't get statically analyzed.
@MichalStrehovsky
Copy link
Member Author

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

@carlossanlop
Copy link
Member

carlossanlop commented Jul 19, 2024

@MichalStrehovsky For my own education, can you please share the output of the error you were seeing? Or if you had an issue open to track it, even better (there's none in the description).

Also, we should merge this before the snap on Monday. Ah, it's test, not critical to merge by then.

@MichalStrehovsky
Copy link
Member Author

@MichalStrehovsky For my own education, can you please share the output of the error you were seeing? Or if you had an issue open to track it, even better (there's none in the description).

It's a nullreferenceexception since either the GetType or GetMethod returned null. It's visible in #104516. I don't file issues for things like this because it's not worth the hassle.

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

/ba-g The reflection test failure on ARM64 was known and has been fixed since the CI ran. Not going to rerun CI for that.

@MichalStrehovsky MichalStrehovsky merged commit 0378936 into main Jul 23, 2024
91 of 105 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-2 branch July 23, 2024 09:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants