Replace Debug.Assert(false, with Debug.Fail(
#105205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-meta |
This was referenced Jul 21, 2024
This was referenced Jul 22, 2024
danmoseley
reviewed
Jul 22, 2024
| @@ -658,7 +658,7 @@ | |||
| // case 0: | |||
| // return x; | |||
| // default: | |||
| // Debug.Assert(false, "Bad field index"); | |||
| // Debug.Fail("Bad field index"); | |||
There was a problem hiding this comment.
this comment says "This code was automatically generated by the TraceParserGen tool" .. unless that tool is updated, whereever it is, the comment probably shouldn't change.
There was a problem hiding this comment.
Seems like the whole file could just be deleted. @brianrob?
There was a problem hiding this comment.
Looks like it's all comments, so yes. @davmason?
There was a problem hiding this comment.
👍Just found it as I catch up on e-mail.
danmoseley
approved these changes
Jul 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.