Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IEnumerator<T> on ref struct enumerators #105273

Closed
wants to merge 1 commit into from
Closed

Implement IEnumerator<T> on ref struct enumerators #105273

wants to merge 1 commit into from

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Jul 22, 2024 •
edited
Loading

Just making sure CI is happy to help validate ref structs implementing interfaces.
#105276

@stephentoub
Implement IEnumerator<T> on ref struct enumerators
b55e774 
Historically we haven't been able to implement `IEnumerator<T>` on our ref struct enumerators. Now we can, so do so.
@stephentoub stephentoub added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Jul 22, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Jul 22, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@stephentoub stephentoub added this to the 10.0.0 milestone Jul 22, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

This was referenced Jul 22, 2024
Closed
Open
Open
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@stephentoub stephentoub

Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@stephentoub