Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-preview7] [browser] Extension agnostic lazy assembly loading #105298

Merged

Conversation

maraf
Copy link
Member

@maraf maraf commented Jul 23, 2024

Backport of #104793

Depends on #105294 (this PR is based on it)

maraf and others added 2 commits July 23, 2024 06:52
* Build and publish integration

* Make fingerpring work at runtime for assemblies

* Make fingerpring work at runtime for icu

* Remove version fingerprint check

* Check core assembly extension

* Typescript nits

* JSModules and SatelliteAssemblies

* DEBUG require newer SDK for testing

* Fix fingerprint for new publish assets

* Lazy loading and FP mapping boot json

* WBT file on disk checks

* WBT file on disk checks

* WBT file on disk checks

* WBT testmain no fingerprint

* WBT revert debug message

* AOT

* WBT fix ordering

* Fingerprinting without webcil

* Fix GenerateWasmBootJson when FP is off

* NoFingerprint WBT variant

* DEBUG try to run WBT without fingerprinting

* WBT make entry comparison order agnostic

* WBT smoke tests for no-fingerprinting

* Update sendtohelix-browser.targets

* Remove debug log

* Fix typo

* Fix regex matching

* Remove test for dotnet.js FP since we don't support that anymore

* Fix check for System.Private.CoreLib

* FP for dotnet.globalization.js

* Fingerprinting pdbs

* WBT fix file check

* Fingerprint segmentation-rules.json

* Fix loading pdb for fingerprinted lazy assembly

* Ensure lazy pdb is loaded

* Remove non-WasmSDK tests from non-FP category

* Revert drop for dotnet.js finterprinting

* Compute non-Fingerprinted virtualPath for pdb and resource as well

* Make debugger working with fingerprinted assemblies and pdbs

* DEBUG latest SDK for WBT

* DEBUG fix wbt installation

* Add WorkloadBuildTasks to WasmBuild.sln

* Fix WBT

* Revert escaping URL in debugger

* Fix lazy loading test and message emit in release config

* Fixes for MT after merge

* Skip WBT without workloads and without fingerprinting

* Turn off fingerprinting when targeting downlevel versions

* Git ignore *.d.ts.sha256

* Fix

* Update source-build-reference-packages to latest

* Revert "Update source-build-reference-packages to latest"

This reverts commit bef50ee.

* Fix the references

* Update Versions.props

* Update Versions.props

---------

Co-authored-by: Larry Ewing <lewing@microsoft.com>
@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Jul 23, 2024
@maraf maraf self-assigned this Jul 23, 2024
@maraf maraf added the Servicing-consider Issue for next servicing release review label Jul 23, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 23, 2024
@carlossanlop
Copy link
Member

carlossanlop commented Jul 23, 2024

@lewing There are many previously unknown CI failures. Are any of them related? Let me know when it's ready to merge.

@maraf
Copy link
Member Author

maraf commented Jul 24, 2024

@lewing There are many previously unknown CI failures. Are any of them related? Let me know when it's ready to merge.

It was caused by some merge damage. Now all the effected files matches content on main.

@lewing
Copy link
Member

lewing commented Jul 24, 2024

@lewing There are many previously unknown CI failures. Are any of them related? Let me know when it's ready to merge.

It was caused by some merge damage. Now all the effected files matches content on main.

Sorry about that

@lewing
Copy link
Member

lewing commented Jul 24, 2024

/ba-g analysis is only red because this is a release branch

@lewing
Copy link
Member

lewing commented Jul 24, 2024

@carlossanlop this is ready now if we still have time

@carlossanlop carlossanlop merged commit 23609ab into dotnet:release/9.0-preview7 Jul 24, 2024
34 of 38 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants