[release/8.0-staging] Build Mono build tasks packs only when targeting mobile #105460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpovazan
added
Servicing-consider
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
rbhanda
added
Servicing-approved
steveisok
approved these changes
Jul 25, 2024
ivanpovazan
merged commit d220439
into
dotnet:release/8.0-staging
98 of 102 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #105153 to release/8.0-staging
Customer Impact
This PR limits building
Microsoft.NET.Runtime.MonoTargets.Sdkpackage only when the build targets mobile platforms. It helps in prevention of publishing different versions of the same package in an official build, which causes issues with symbol verification during VS insertion. More details on the exact encountered scenario are provided in the description of #105153.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Verified that on the
mainbranch official build succeeds producing required packages.Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.