ARM64-SVE: Fix Comment group headers in SVE API (#104846) #105679
Conversation
Also fix up Scatter summary blocks.
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
|
@dotnet/arm64-contrib @kunalspathak |
a74nh
changed the title
| /// <summary> | ||
| /// void svst1_scatter_[s32]offset[_s32](svbool_t pg, int32_t *base, svint32_t offsets, svint32_t data) | ||
| /// ST1W Zdata.S, Pg, [Xbase, Zoffsets.S, SXTW] | ||
| /// </summary> | ||
| public static unsafe void Scatter(Vector<int> mask, int* address, Vector<int> indicies, Vector<int> data) { throw new PlatformNotSupportedException(); } | ||
|
|
||
| // <summary> |
There was a problem hiding this comment.
It looks like the APIs that are commented out for now didn't get updated to ///. I'm alright leaving these as-is for now, just pointing this out for future work.
There was a problem hiding this comment.
AIUI, The ones that are commented out should remain as // because then the summary doesn't end up in the docs.
|
@a74nh do you have permission to merge your own PRs? If not, I'm happy to do that for you. |
I got some permissions recently, but not that as far as I can tell. If you could merge for me that'd be great, thanks! |
Also fix up Scatter summary blocks.
This was mostly done via regex.
Personally, I'd prefer of the form
// AddSaturate : Saturating add, (ie add the method name to the start of the comment). But happy enough with how it is in the PR.There are still quite a few additional changes that need making to these files to tidy them up, but I'll put them in separate PRs to simplify the review process.
Fixes #104846