-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILLink: Keep parameter names unless DebuggerSupport is disabled #105714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-Tools-ILLink
.NET linker development as well as trimming analyzers
label
Jul 30, 2024
dotnet-policy-service
bot
added
the
linkable-framework
Issues associated with delivering a linker friendly framework
label
Jul 30, 2024
MichalStrehovsky
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: did you consider adding a TrimmingTest? (Testing this could probably be approximated with trim-unsafe reflection and we could have variants for both DebuggerSupport=false and the default.)
This was referenced Aug 7, 2024
/ba-g "unrelated timeout in browser-wasm linux Release WasmBuildTests" |
rolfbjarne
added a commit
to xamarin/xamarin-macios
that referenced
this pull request
Aug 9, 2024
This was referenced Aug 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-Tools-ILLink
.NET linker development as well as trimming analyzers
linkable-framework
Issues associated with delivering a linker friendly framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102873
Parameter name trimming is currently the only metadata trimming optimization, but I put "all" under this check to include any future metadata trimming optimizations that might impact debuggers.
@dotnet/appmodel PTAL