Add support for doubly nested intrinsic classes #105761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
3 tasks
This was referenced Aug 2, 2024
|
cc @dotnet/jit-contrib PTAL @tannergooding @MichalStrehovsky @jkotas |
tannergooding
approved these changes
Aug 6, 2024
jkotas
reviewed
Aug 7, 2024
| @@ -22,7 +22,9 @@ public static bool IsHardwareIntrinsic(MethodDesc method) | |||
| if (owningType.IsIntrinsic && !owningType.HasInstantiation) | |||
| { | |||
| var owningMdType = (MetadataType)owningType; | |||
| string ns = owningMdType.ContainingType?.Namespace ?? owningMdType.Namespace; | |||
| string ns = owningMdType.ContainingType?.ContainingType?.Namespace ?? | |||
There was a problem hiding this comment.
Nit: It would be nice to avoid calling the virtual ContainingType property multiple times.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Runtime.Intrinsics.X86.Avx10v1+V512+X64.IsSupportedcurrently results in an infinite loop. This PR fixes the problem by adding support in various places for hardware intrinsic classes nested more than once.getMethodNameFromMetadatato allow returning names of multiple enclosing classesAvx10v1supportFix #105402