-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comments around static constructor memory #105911
Conversation
Delete unnecessary MemoryBarrier Fixes dotnet#81151
...coreclr/nativeaot/Test.CoreLib/src/System/Runtime/CompilerServices/ClassConstructorRunner.cs
Show resolved
Hide resolved
...System.Private.CoreLib/src/System/Runtime/CompilerServices/StaticClassConstructionContext.cs
Show resolved
Hide resolved
We also access the Line 36 in 1cc0186
For completeness of the fix those should also be volatile reads. Ideally that would be in C#, so less trouble with hand encoded assembly. Not sure what scenario uses those (Reflection?) and whether it would be noticeable if the stubs do not try to short-circuit and just call here unconditionally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think the asm stubs could be dealt with separately. |
Delete unnecessary MemoryBarrier
Contributes to #81151