Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS][HybridGlobalization] Handle small buffer case in sortkey #106062

Merged
merged 2 commits into from
Aug 9, 2024
Merged

[iOS][HybridGlobalization] Handle small buffer case in sortkey #106062

merged 2 commits into from
Aug 9, 2024

Conversation

mkhamoyan
Copy link
Member

fixes #105932

@mkhamoyan mkhamoyan self-assigned this Aug 7, 2024
@mkhamoyan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

This was referenced Aug 7, 2024
Closed
Closed
Open
Closed
Open
Open
Open
Open
Closed
Open
@mkhamoyan mkhamoyan marked this pull request as ready for review August 7, 2024 11:52
matouskozak
matouskozak approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@matouskozak matouskozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fix.

src/native/libs/System.Globalization.Native/pal_collation.m Show resolved Hide resolved
@mkhamoyan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 8, 2024
Closed
Open
@mkhamoyan mkhamoyan merged commit 0f2ce10 into dotnet:main Aug 9, 2024
190 of 207 checks passed
@mkhamoyan mkhamoyan deleted the fix_sortkey_exception branch August 9, 2024 08:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matouskozak matouskozak matouskozak approved these changes

@ilonatommy ilonatommy Awaiting requested review from ilonatommy

Assignees

@mkhamoyan mkhamoyan

Labels
area-System.Globalization os-ios Apple iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Apple-mobile] Segfault when retrieving native sort key on apple platforms.
2 participants
@mkhamoyan @matouskozak