[wasm] Be more cautious about page zeroing #106080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
reviewed
Aug 7, 2024
| @@ -125,7 +125,7 @@ static unsigned long | |||
| prot_flags_for_activate (int activate) | |||
| { | |||
| unsigned long prot_flags = activate? MONO_MMAP_READ|MONO_MMAP_WRITE: MONO_MMAP_NONE; | |||
| return prot_flags | MONO_MMAP_PRIVATE | MONO_MMAP_ANON | MONO_MMAP_NOZERO; | |||
| return prot_flags | MONO_MMAP_PRIVATE | MONO_MMAP_ANON; | |||
There was a problem hiding this comment.
should some of this be ifdef WASM ?
There was a problem hiding this comment.
It currently has no effect on other platforms, so it doesn't need to be
lambdageek
approved these changes
Aug 7, 2024
This was referenced Aug 7, 2024
This was referenced Aug 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #106007